Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add main branch workflows #244

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Add main branch workflows #244

merged 2 commits into from
Mar 2, 2023

Conversation

mitchellolsthoorn
Copy link
Member

@mitchellolsthoorn mitchellolsthoorn commented Mar 1, 2023 •
edited by dstallenberg
Loading

Previously, we only had build and quality workflows for PRs. To allow us to show build and quality status badges on the README, we need to also run these workflows on the main branch.

Closes #246
Closes #243

@mitchellolsthoorn
ci: add main branch workflows
5c149de 
Previously, we only had build and quality workflows for PRs. To allow us
to show build and quality status badges on the README, we need to also
run these workflows on the main branch.
@mitchellolsthoorn mitchellolsthoorn requested a review from a team as a code owner March 1, 2023 12:36
@mitchellolsthoorn mitchellolsthoorn linked an issue Mar 1, 2023 that may be closed by this pull request
Make sure build and verify workflow also work on main #243
Closed
@coveralls
Copy link
Collaborator

coveralls commented Mar 1, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4312660998

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Totals Coverage Status
Change from base Build 4302180295: 0.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

@dstallenberg
ci: set fetch-depth to 0
27b2a8a 
The default fetch-depth of 1 only gets the latest commit without any tags or history.
For the lerna version/publish workflows it requires the git history.
dstallenberg
dstallenberg approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@dstallenberg dstallenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes!

@dstallenberg dstallenberg merged commit b62cc22 into main Mar 2, 2023
@dstallenberg dstallenberg deleted the 243-make-sure-build-and-verify-workflow-also-work-on-main branch March 2, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstallenberg dstallenberg dstallenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish workflow not adhering to changed packages Make sure build and verify workflow also work on main
3 participants
@mitchellolsthoorn @coveralls @dstallenberg