fix: improve errors and results from test executor (#209)

syntest-framework · Dec 11, 2023 · 4cdc920 · 4cdc920
1 parent 8bbb66d
commit 4cdc920
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 5 deletions.
diff --git a/libraries/search-javascript/lib/testcase/execution/JavaScriptRunner.ts b/libraries/search-javascript/lib/testcase/execution/JavaScriptRunner.ts
@@ -112,7 +112,14 @@ export class JavaScriptRunner implements EncodingRunner<JavaScriptTestCase> {
       childProcess.on("message", (data: Message) => {
         if (typeof data !== "object") {
           return reject(
-            new TypeError("Invalid data received from child process")
+            new ImplementationError(
+              "Invalid data received from child process",
+              {
+                context: {
+                  data: data,
+                },
+              }
+            )
           );
         }
 

diff --git a/libraries/search-javascript/lib/testcase/execution/TestExecutor.ts b/libraries/search-javascript/lib/testcase/execution/TestExecutor.ts
@@ -128,9 +128,9 @@ async function runMocha(silent: boolean, paths: string[], timeout: number) {
           error:
             status === JavaScriptExecutionStatus.FAILED
               ? {
-                  name: test.err.name,
-                  message: test.err.message,
-                  stack: test.err.stack,
+                  name: test.err ? test.err.name : "",
+                  message: test.err ? test.err.message : "",
+                  stack: test.err ? test.err.stack : "",
                 }
               : undefined,
           duration: test.duration,
@@ -153,7 +153,24 @@ async function runMocha(silent: boolean, paths: string[], timeout: number) {
   resetInstrumentationData();
   (<GlobalType>(<unknown>global)).__meta__ = undefined;
   (<GlobalType>(<unknown>global)).__assertion__ = undefined;
-  process.send(result);
+
+  const cache = new Set();
+
+  // This is to prevent circular references
+  // TODO this actually removes all repeating values which is not good
+  process.send(
+    JSON.parse(
+      JSON.stringify(result, (_, value) => {
+        if (typeof value === "object" && value !== null) {
+          if (cache.has(value)) return;
+
+          cache.add(value);
+        }
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-return
+        return value;
+      })
+    )
+  );
 
   mocha.dispose();
 }

diff --git a/libraries/search-javascript/lib/testcase/statements/action/ConstructorCall.ts b/libraries/search-javascript/lib/testcase/statements/action/ConstructorCall.ts
@@ -17,6 +17,7 @@
  */
 
 import { Export, TypeEnum } from "@syntest/analysis-javascript";
+import { ImplementationError } from "@syntest/diagnostics";
 import { prng } from "@syntest/prng";
 
 import { ContextBuilder } from "../../../testbuilding/ContextBuilder";
@@ -59,6 +60,11 @@ export class ConstructorCall extends ActionStatement {
       arguments_,
       export_
     );
+    if (!export_) {
+      throw new ImplementationError(
+        "Export of constructor call cannot be undefined"
+      );
+    }
     this._classIdentifier = classIdentifier;
   }