Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some spec descriptions are missing an aesthetic terminating quote #285

Closed
synthead opened this issue Jul 5, 2023 · 0 comments · Fixed by #286
Closed

Some spec descriptions are missing an aesthetic terminating quote #285

synthead opened this issue Jul 5, 2023 · 0 comments · Fixed by #286
Assignees
Labels
bug Something isn't working protocol 1 Specific to protocol 1 protocol 3 Specific to protocol 3 protocol 4 Specific to protocol 4 protocol 6 Specific to protocol 6 protocol 9 Specific to protocol 9

Comments

@synthead
Copy link
Owner

synthead commented Jul 5, 2023

This context description:

context "when name is \"<>[" do
let(:name) { "<>[" }
it_behaves_like "CRC-wrapped packets", [
[0x31, 0x01, 0x3c, 0x3d, 0x3e]
]
end

...is missing an aesthetic terminating quote. This should read:

context "when name is \"<>[\"" do

There are a few places in the specs that have this missing quote 👍

@synthead synthead self-assigned this Jul 5, 2023
@synthead synthead added bug Something isn't working protocol 1 Specific to protocol 1 protocol 3 Specific to protocol 3 protocol 9 Specific to protocol 9 protocol 6 Specific to protocol 6 protocol 4 Specific to protocol 4 labels Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working protocol 1 Specific to protocol 1 protocol 3 Specific to protocol 3 protocol 4 Specific to protocol 4 protocol 6 Specific to protocol 6 protocol 9 Specific to protocol 9
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant