Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pairwise distance and dendrogram plots in fairness scorer #134

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Hilly12
Copy link
Contributor

@Hilly12 Hilly12 commented Sep 17, 2021

  • Add feature to measure fairness between pairs of different combinations of subgroups for asymmetric metrics.
  • Add feature to plot dendrograms, i.e., hierarchical cluster trees produced by clustering the unique values in each sensitive column.
  • Fix plot scaling
    770a537b-6a2d-4dc4-a6b1-b8834aebcd0d

Closing #133 #121

@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #134 (9e59e26) into main (f68761c) will increase coverage by 0.80%.
The diff coverage is 87.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
+ Coverage   76.33%   77.13%   +0.80%     
==========================================
  Files          16       16              
  Lines        1010     1076      +66     
  Branches      218      239      +21     
==========================================
+ Hits          771      830      +59     
- Misses        192      195       +3     
- Partials       47       51       +4     
Flag Coverage Δ
unittests 77.13% <87.34%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/fairlens/scorer.py 78.31% <85.91%> (+5.41%) ⬆️
src/fairlens/plot/distr.py 87.96% <100.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f68761c...9e59e26. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

90.8% 90.8% Coverage
8.8% 8.8% Duplication

@simonhkswan simonhkswan added the type:feature New API or feature. label Sep 24, 2021
@simonhkswan simonhkswan self-requested a review September 24, 2021 14:53
@sonarcloud
Copy link

sonarcloud bot commented Sep 24, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.3% 92.3% Coverage
0.0% 0.0% Duplication

@simonhkswan simonhkswan removed their request for review April 4, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New API or feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pairwise distance computation in the fairness scorer Plot scaling
2 participants