Configure metrics with yaml #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…io/insight into configure_metrics_with_yaml
simonhkswan
requested changes
Jul 11, 2022
| return {'name': self.name} | ||
|
|
||
| @classmethod | ||
| def metric_from_dict(cls, bluprnt: Dict[str, Any], check: Check = None): |
There was a problem hiding this comment.
Suggested change
| def metric_from_dict(cls, bluprnt: Dict[str, Any], check: Check = None): | |
| def from_dict(cls, bluprnt: Dict[str, Any], check: Check = None): |
Comment on lines
50
to
66
| @classmethod | ||
| def metrics_to_yaml_dump(cls, metrics: List): | ||
| """ | ||
| Dumps the given metrics into the print stream in a YAML format. | ||
| This is a prototype function and should be deleted/modified later. | ||
| """ | ||
| print(yaml.dump({"metrics": [m.to_dict() for m in metrics]})) | ||
|
|
||
| @classmethod | ||
| def metrics_from_yaml(cls, document: Union[IO, str], check: Check = None): | ||
| """ | ||
| Given a YAML document that contains a 'metrics' field, return a list of instances of the metrics within | ||
| the field. | ||
| """ | ||
| metric_bluprnts = yaml.safe_load(document) | ||
| return [_Metric.metric_from_dict(bluprnt=bluprnt, check=check) for bluprnt in metric_bluprnts['metrics']] | ||
|
|
There was a problem hiding this comment.
lets pull out these two methods
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.