Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't connect to dApp after switching account. #294

Closed
shawnwang0715 opened this issue Dec 15, 2021 · 5 comments
Closed

Can't connect to dApp after switching account. #294

shawnwang0715 opened this issue Dec 15, 2021 · 5 comments

Comments

@shawnwang0715
Copy link
Contributor

When switching accounts in the MetaMask notification window, it would show a prompt to let you connect the next account to your dApp. However synpress switches accounts in a new tab of MetaMask (expanded view). In this case, the prompt won't show, so the new account won't be able to interact with the dApp...

I guess one workaround is that make synpress 'select all' accounts when it makes MetaMask connect to the dApp for the first time.

@drptbl
Copy link
Member

drptbl commented Dec 20, 2021

Hey @shawnwang0715, thanks for feedback.

I will investigate this soon.

@avp1598
Copy link

avp1598 commented Jan 12, 2022

Hi @drptbl I have a potential fix for this, which is to accept access to all accounts instead of just 1. However I am not familiar with the process of merging this fix with the library. Should I just raise a PR?

@drptbl
Copy link
Member

drptbl commented Jan 12, 2022

Hey @avp1598, that's great to hear. Yes, please open a new PR. Thanks! 💪

@DanyalKhawaja
Copy link

I assume you have already resolved it, otherwise cy.acceptMetamaskAccess(true); will connect all accounts

@shawnwang0715
Copy link
Contributor Author

Yes, I created the PR. Thanks for reminding me to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants