Monkeypatch patsy with with faster handling of boolean categoricals #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In urbansim we know that data passing through patsy will always be pandas Series instances. We can capitalize on that in a couple places to avoid expensive categorical nan checking. What we do instead is to check the dtype of the data and if it is boolean take appropriate action without actually looking at the data. Actually patched are the function patsy.categorical.categorical_to_int and the method patsy.categorical.CategoricalSniffer.sniff.
|
Going to do a little more testing on this to make sure the patch has actually been applied when models are running. |
jiffyclub
added a commit
that referenced
this pull request
May 28, 2014
Monkeypatch patsy with with faster handling of boolean categoricals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In urbansim we know that data passing through patsy will always be pandas Series instances. We can capitalize on that in a couple places to avoid expensive categorical nan checking. What we do instead is to check the dtype of the data and if it is boolean take appropriate action without actually looking at the data.
Actually patched are the function
patsy.categorical.categorical_to_intand the methodpatsy.categorical.CategoricalSniffer.sniff.There may end up being discussion around these changes on a PR I submitted to patsy at pydata/patsy#44.