improve automation to allow for synthesizing instruments

[ahicks92]

Originally, the idea was that automation would be relative to the 0 time of the local object, but it turned out that this was hard to do: synchronizing automation of different objects wouldn't have been possible without introducing a way to instead be relative to the context. In order to get the API out the door, automation was made context-relative globally, and this limitation was accepted. But we can probably do better, it's just going to take work to make that happen. Since the original plan wasn't to eve introduce this API before 1.0, this issue is being deferred.

See #73 for the original portion of this work.

[chrisnorman7]

Hi,
Using the latest release (v0.11.2), it seems as though automation only works with SYZ_P_CURRENT_TIME, and not SYZ_P_SUGGESTED_AUTOMATION_TIME.

As far as git diff can tell me, the only difference is that you gave the previously-unnamed union the name `syz_AutomationCommandParams", so not sure if the API has changed in a way I don't know about?

[chrisnorman7]

Actually, scratch that: I just ran the examples in the synthizer/build directory, and they're not working anymore either, at least for me.

[ahicks92]

The union rename thing isn't even released yet.

But you're right, even though I literally just built a working Rust example, the C-side ones are somehow broken. I will work on this, though admittedly it really deserves a separate issue.

[ahicks92]

Ok, have a one line fix. Let me know if that's good and I'll do a release across all the places.

[chrisnorman7]

Oh, sorry about that. I got an email saying the new version was released, so I went ahead and built. Do you have a branch that I can track that represents the latest version? Then I can stop complaining about bugs you probably already know about. No worries if not. Take care, Chris Norman

…

On Wed, 13 Oct 2021 at 22:50, Austin Hicks ***@***.***> wrote: The union rename thing isn't even released yet. But you're right, even though I literally just built a working Rust example, the C-side ones are somehow broken. I will work on this, though admittedly it really deserves a separate issue. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#78 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBUZ2O4WGPAEVCK4QVGDPLUGX5LVANCNFSM5FYZ43OA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[ahicks92]

You're supposed to check out the git tags as your submodule or wherever/however you're doing it. That said this bug got released, you were just a couple commits that happened to be NFC ahead. See above though, it should be fixed on master, if you can confirm I'll roll it out.

[chrisnorman7]

Ah fair enough. Yes, it's working now, thanks. Take care, Chris Norman

…

On Thu, 14 Oct 2021 at 15:09, Austin Hicks ***@***.***> wrote: You're supposed to check out the git tags as your submodule or wherever/however you're doing it. That said this bug got released, you were just a couple commits that happened to be NFC ahead. See above though, it should be fixed on master, if you can confirm I'll roll it out. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#78 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBUZ2KQC3OZLSD53IC46G3UG3QCTANCNFSM5FYZ43OA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.