Sanitize mentions in cleanup (prior to role logic)

[shikhir-arora]

Per DM, opening PR. Sanitizes mentions in the raw article via. the cleanup function with a zero-width space. This makes all mentions (such as @everyone - that could be contained in the RSS body) not get triggered on Discord but does not affect the output, nor has any impact on subscribed roles, as that logic is done after this cleanup.

[synzen]

Good catch, but what is the purpose of this?
text.replace(/`/g, '\`' + String.fromCharCode(8203))

[shikhir-arora]

Good catch, but what is the purpose of this?
text.replace(/`/g, '\`' + String.fromCharCode(8203))

An additional safety check that sanitizes markdown-enclosed stuff, so `@hello` would be caught by adding a zero-width after `, and then adding the zero-width after @ which will make the mention not trigger.

[synzen]

Ah so you're escaping backticks as well - in that case, did you mean to do

text.replace(/`/g, '\\`' + String.fromCharCode(8203))

then? A single backslash unnecessarily escapes the backtick, which is just equivalent to a backtick rather than a backslash and a backtick

[shikhir-arora]

Ah so you're escaping backticks as well - in that case, did you mean to do

text.replace(/`/g, '\\`' + String.fromCharCode(8203))

then? A single backslash unnecessarily escapes the backtick, which is just equivalent to a backtick rather than a backslash and a backtick

I may be misexplaining it. Pictures are worth a thousand words they say, so here's a few:

• Normal case (no sanitizing): https://www.dropbox.com/s/bct19ukggass2e6/Screenshot%202019-02-06%2019.49.18.png?dl=0

• Sanitizing a normal mention (most of the use case):
  https://www.dropbox.com/s/pvqgs0jgj7rn3o4/Screenshot%202019-02-06%2019.53.54.png?dl=0
  https://www.dropbox.com/s/42p00rrt53jzm21/Screenshot%202019-02-06%2019.49.57.png?dl=0

• Sanitizing ` as shown: https://www.dropbox.com/s/ch2zfvu4nb8r5ht/Screenshot%202019-02-06%2019.50.18.png?dl=0 (notice that the output here is not triggered by Discord, so it's protecting against sending ` ` with a mention and the output is cleaned)

[synzen]

It seems like you're trying to escape backticks - I have tried this:

function clean1 (text) {
  return text.replace(/`/g, '\`' + String.fromCharCode(8203))  // Sanitize mentions with zero-width character "\u200b"
    .replace(/@/g, '@' + String.fromCharCode(8203))
}

function clean2 (text) {
  return text.replace(/`/g, String.fromCharCode(8203))  // Sanitize mentions with zero-width character "\u200b"
    .replace(/@/g, '@' + String.fromCharCode(8203))
}


client.on('message', msg => {
  if (!msg.author.bot) {
    msg.channel.send(clean1(msg.content))
    msg.channel.send(clean2(msg.content))
  }
})

clean1 is your function, but the second message's clean1 result does not equate to yours

The clean2 function seems to do what you want however.

But overall, does the backtick replacement relate to escaping mentions? It seems like it would work fine without the first replace.

[shikhir-arora]

But overall, does the backtick replacement relate to escaping mentions? It seems like it would work fine without the first replace.

It doesn't matter much here, from the standpoint that this is an edge case. I'll remove that now.