Modernize #433
Merged
Modernize #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyollb
commented
Jun 21, 2023
| std::string uri; | ||
| int bufferView{-1}; // (required if no uri) | ||
| std::string | ||
| mimeType; // (required if no uri) The audio's MIME type. Required if |
There was a problem hiding this comment.
this is because of the .clang-format, i guess character limit per line.
There was a problem hiding this comment.
There are several format changes unrelated to real changes. I guess the .clang-format was only partly used to format the code previously.
|
Nice! Each changes seems trivial, but lots of changes... Need some time to review it and ensure no side-effect exists. |
|
Run some tests and seems no side-effects observed, so merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modernizes the code a bit, replacing member initialization lists by default member initialization.
This is related to 7a570c8#r119070408
I used clang-tidy to refactor the code. The following checks were used: