Handle the situation where the recorded component type does not match the required type for the actual number of stored points #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it'd be better to provide user callback functions for Draco decoding/encoding for flexibility, not implement workaround in the builtin Draco decoding function. PR of callback functions for Draco decoding/encoding is much appreciated! |
|
@nyalldawson Yes, could you please modify this PR so that the situation is only considered when strictness flags is PERMISSIVE, like this?: |
recorded component type does not match the required type for the actual number of stored points This situation arises when decoding certain malformed files, most notably it's seen in glb tiles from Google Earth's 3d tileset. It's a port of the workaround used by Cesium native here: https://github.com/CesiumGS/cesium-native/blob/d9172461e2d53f19d050ebc39f24a4f4ef5b9224/CesiumGltfReader/src/decodeDraco.cpp#L101
nyalldawson
force-pushed
the
draco_fix
branch
from
84bcf50
to
6e3d666
Compare
|
@syoyo ok, that's done. I've also made it add a warning string when the component type is upgraded when in permissive mode. |
|
Awesome! Thanks! Merged! TODO: This is still much appreciated 🥺 > PR of callback functions for Draco decoding/encoding is much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This situation arises when decoding certain malformed files, most notably it's seen in glb tiles from Google Earth's 3d tileset.
It's a port of the workaround used by Cesium native here:
https://github.com/CesiumGS/cesium-native/blob/d9172461e2d53f19d050ebc39f24a4f4ef5b9224/CesiumGltfReader/src/decodeDraco.cpp#L101