Always use size_t for byte offsets #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes silently writing an overflowed int in the output file.
|
Good catch! https://registry.khronos.org/glTF/specs/2.0/glTF-2.0.html#_accessor_byteoffset The spec says byteOffset is ">=0", so we can use size_t(uint). |
|
Merged! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I had a glft file with a single large buffer which i then used in many bufferViews/accessors.
This ended up silently creating an invalid file with negative byteOffsets due to a size_t->int cast overflowing in serialization.
This request fixes that serialization bug, and uses size_t for all byte offsets, instead of a mix depending on struct (bufferView, accessor, accessor::Sparse)