Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Depth will not be set correctly via CLI if depth=0 is set #69

Closed
sypets opened this issue Jun 24, 2021 · 0 comments · Fixed by #70
Closed

[BUG] Depth will not be set correctly via CLI if depth=0 is set #69

sypets opened this issue Jun 24, 2021 · 0 comments · Fixed by #70
Labels
is::bug Something isn't working

Comments

@sypets
Copy link
Owner

sypets commented Jun 24, 2021

Describe the bug

Depth=0 is interpreted as unset option and the default is used.

To Reproduce

  1. Call CLI command with depth=0

vendor/bin/typo3 brofix:checklinks -p 1 -d 0 --dry-run

The default depth (999) or the depth set via Page TSconfig is used. This is not correct.

Expected behavior

A depth of 0 should be used.

System (please complete the following information):

  • TYPO3 version: 10.4.17
  • brofix version: 2.1.1-dev
  • installed with Composer: no
@sypets sypets added the is::bug Something isn't working label Jun 24, 2021
sypets added a commit that referenced this issue Jun 24, 2021
@sypets
[BUGFIX] Fix setting depth=0
6705586 
If a depth=0 is set via the CLI command brofix:checklinks,
it is interpreted as unset option and the default is used.

Resolves: #69
@sypets sypets mentioned this issue Jun 24, 2021
Merged
sypets added a commit that referenced this issue Jun 24, 2021
@sypets
[BUGFIX] Fix setting depth=0 (#70)
077ecf2 
If a depth=0 is set via the CLI command brofix:checklinks,
it is interpreted as unset option and the default is used.

Resolves: #69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is::bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] Fix setting depth=0 sypets/brofix
1 participant
@sypets