Add filters and sorting on date of check in Report

[atigiti]

I tried to add filters functionality and also the sorting on date of check in Report

[sypets]

@atigiti Thank you for your PR. I tested it and like the functionality. In the actions , you can see that some checks failed (you can also see that in the PR).

Since these are minor issues (coding guidelines, phpstan functional tests), I already pushed some fixes.

In the future you can perform the checks locally yourself, and in the case of coding guidelines (CGL) even fix them locally.

Please see the file CONTRIBUTING.md for more info.

Also, I adhere to TYPO3 core best practices as much as possible, core also enforces CGL checks and uses phpstan.

Example: phpstan complains about this but I also prefer to add type hints as much as possible, e.g.

-    public function setStorageKey($storageKey)
+    public function setStorageKey(string $storageKey): void

I will give the patch a more thorough review next, the above are more general things.

[atigiti]

Thank you for your response, I will start to run the local tests before the PR, thanks also for changing the getBrokenLinks signature!

[atigiti]

i'm trying also to add a new Tab in the info module, for Manage the exclusions links.

[sypets]

Great change, I especially like the possibility to filter for URL. I tested and it works if sorting is changed and also works with pagination.

I made some comments. If you can get these fixed, that would be great.

I already mentioned the phpstan, CGL, test things - that might be something to do in future PR.

[atigiti]

@atigiti Thank you for your PR. I tested it and like the functionality. In the actions , you can see that some checks failed (you can also see that in the PR).

Since these are minor issues (coding guidelines, phpstan functional tests), I already pushed some fixes.

In the future you can perform the checks locally yourself, and in the case of coding guidelines (CGL) even fix them locally.

Please see the file CONTRIBUTING.md for more info.

Also, I adhere to TYPO3 core best practices as much as possible, core also enforces CGL checks and uses phpstan.

Example: phpstan complains about this but I also prefer to add type hints as much as possible, e.g.

-    public function setStorageKey($storageKey)
+    public function setStorageKey(string $storageKey): void

I will give the patch a more thorough review next, the above are more general things.

i have a question please, how can use the phpstan in typo3 project ???

[sypets]

@atigiti It depends - if you want to use it to test brofix or set it up for your project

normally, you can do this (after you setup the phpstan.neon):

composer require phpstan/phpstan
php vendor/bin/phpstan analyse --no-progress --no-interaction --memory-limit 4G  -c phpstan.neon

For brofix however, the test suite is setup to run via runTests.sh using this instruction: https://docs.typo3.org/m/typo3/reference-coreapi/10.4/en-us/Testing/ExtensionTesting.html
For runTests.sh to work you need to install Docker and Docker compose. This may seem like overkill for phpstan but you can also run the functional tests that way which require a database to be setup etc. and for this the Docker container is handy.

You must first do the equivalent of composer install:

In the brofix directory:

Build/Scripts/runTests.sh -p 7.4 -s composerInstallMax

After that, you can call phpstan with

composer ci:phpstan

---

Sorry, if this seems a bit complicated. I may still change things in the future.

You can also look here:

• .github/workflows/ci.yaml : this is what is run on GitHub
• a script version of this is in Build/Scripts/ci

---

You can also come to the Slack workspace and write me a direct message to @sybille. Patrick knows how to get access to Slack.
`

[atigiti]

@atigiti It depends - if you want to use it to test brofix or set it up for your project

normally, you can do this (after you setup the phpstan.neon):

composer require phpstan/phpstan
php vendor/bin/phpstan analyse --no-progress --no-interaction --memory-limit 4G  -c phpstan.neon

For brofix however, the test suite is setup to run via runTests.sh using this instruction: https://docs.typo3.org/m/typo3/reference-coreapi/10.4/en-us/Testing/ExtensionTesting.html For runTests.sh to work you need to install Docker and Docker compose. This may seem like overkill for phpstan but you can also run the functional tests that way which require a database to be setup etc. and for this the Docker container is handy.

You must first do the equivalent of composer install:

In the brofix directory:

Build/Scripts/runTests.sh -p 7.4 -s composerInstallMax

After that, you can call phpstan with

composer ci:phpstan

Sorry, if this seems a bit complicated. I may still change things in the future.

You can also look here:

• .github/workflows/ci.yaml : this is what is run on GitHub
• a script version of this is in Build/Scripts/ci

You can also come to the Slack workspace and write me a direct message to @sybille. Patrick knows how to get access to Slack. `

Thank you for your help!

[atigiti]

in my last commit, i tried to fix all point in the code that you mentioned after your code check, i also run the tests and phpstan for code review, i hope thaht will be helpful!

[sypets]

@atigiti I pushed a fix for the CGL issue

The pipepline has run executing the tests: https://github.com/sypets/brofix/actions/runs/1341403243

see Actions

You can fix coding guideline issues locally: Build/Scripts/runTests.sh -s cgl
You can also run some basic tests locally with the script: Build/Scripts/ci.sh

see https://github.com/sypets/brofix/blob/master/CONTRIBUTING.md

These commands are still work-in-progress, will optimize and then update CONTRIBUTING.md