Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis with GitHub workflows #26

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Conversation

markedwards
Copy link
Collaborator

Replaces the broken Travis setup with GitHub workflows, and updates the badges in README.md.

Also includes a refactor in aiodataloader.py to resolve flake8 errors.

@markedwards markedwards force-pushed the github-workflows branch 3 times, most recently from 6573e51 to d9acb8e Compare October 5, 2022 12:28
@markedwards
Copy link
Collaborator Author

@syrusakbary or @Cito, any comments on this? Probably further additions or improvements can be made, but I want to get the pipelines running in an equivalent manner first.

@Cito
Copy link

Cito commented Oct 6, 2022

@markedwards Looks good to me.

@markedwards markedwards merged commit a4739d8 into master Oct 6, 2022
@markedwards
Copy link
Collaborator Author

markedwards commented Oct 6, 2022

@markedwards Looks good to me.

Thanks for taking a look @Cito. Could also use your attention on #25 if you have bandwidth. That's the next goal, to make aiodataloader fully typed, and that probably means dropping support for python 3.5.

The diff is still a work-in-progress, so still a bunch left to do there. But prior to actually merging and doing a subsequent release, would love more eyes.

@Cito
Copy link

Cito commented Oct 6, 2022

PR #25 also looks good to me, but currently don't have the bandwidth to test or check in detail. And yes, you should definitely drop Python 3.5. It is not supported by GraphQL-Core 3 and in the upcoming 3.3 release of GraphQL-core I'll even drop Python 3.6 (EOL was Dec 2021). Also check compatibility/necessity of typing_extensions with various Python versions.

@markedwards markedwards deleted the github-workflows branch November 16, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants