Change typing of batch_load_fn to support subclass overriding #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a
Protocol
to typebatch_load_fn
does not play well with the documented pattern of overriding the method in a subclass.For instance:
This causes mypy to complain
Signature of "batch_load_fn" incompatible with supertype "DataLoader"
.Fixing by typing
batch_load_fn
asCallable[[List[KeyT]], Coroutine[Any, Any, List[ReturnT]]]
, which also avoids the conditional import ofProtocol
.