-
Notifications
You must be signed in to change notification settings - Fork 74
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
5177e53
commit 65dbcbf
Showing
3 changed files
with
321 additions
and
244 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
65dbcbf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@syrusakbary, was the trampoline re-allowed on purpose in this commit, or is it a bug? It was earlier disabled by default in PR #37.
We use graphene in wsgi threaded server and with sqlalchemy scoped thread local sessions and we rely on executing whole graphene query (all resolvers) in the same thread. It would help if the docs was clearer on execution, even better configurable through schema execute method.
I figured out that totally synchronous thread safe execution can only be achieved with combination of SyncExecutor in graphene, ImmediateScheduler and disabled trampoline in promises async_instance.