Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually add the PEP 561 typed module marker. #66

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

ppentchev
Copy link
Contributor

Hi,

Thanks a lot for writing and maintaining this excellent promise module!

When adding promise support to a module that I'm still writing, I found out that although in version 2.2 you added the py.typed marker file to setup.py's package_data dictionary, it does not actually exist, so it is not really distributed and the mypy checker did not believe me that your module was really fully typed :) What do you think about this trivial commit that fixes that?

Thanks again, and keep up the great work!

G'luck,
Peter

@syrusakbary syrusakbary merged commit 729c35a into syrusakbary:master Dec 18, 2019
@ppentchev ppentchev deleted the roam-py-typed branch January 22, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants