Fix Python 3.7 deprecation warnings #67
Conversation
Importing ABCs directly from the `collections` module is deprecated in Python 3.7.
elprans
force-pushed
the
fix-collections-deprecation-warning
branch
from
f64eea1
to
c088f7c
Compare
|
It would be nice to get this merged. What is the status? |
|
The CI failed, but it does not seem to be caused by this PR. It would be a good idea to add Python 3.7 to the travis XML. @syrusakbary: can you please release a version with these warnings fixed? Python 3.7 is now the default version of Python in Homebrew (MacOSX). |
|
Python 3.8.0 is now out. The deprecation warning has been extended to 3.9 so this doesn't block upgrades but it would still make my day if this could get cut into a new release to kill the warnings. As commented above, the CI failure is not related to the changes Any chance someone has spare eyes for this? |
|
The core problem here is mypy isn't version pegged, so new versions find new problems. I've created a PR, based on this PR, to fix the mypy errors: #79 I am unclear whether the lack of a mypy version is intentional or not, so I left that alone. |
Importing ABCs directly from the
collectionsmodule is deprecatedin Python 3.7.