-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a custom user-agent #7
Comments
This is already implemented, correct me if I am wrong: https://curl.haxx.se/docs/manpage.html#-A |
I see. The User Agent is being sent in the
|
This resolves #7 by using a User-Agent string that follows the standard format defined in rfc7231. Currently using the following: Product/Version (Comment)
Prompt user for custom user-agent else use default value |
I'm not sure it's a good idea to allow changing the User-Agent. Not by default at least since anyone can still edit the code and modify it. But the idea of the user agent here is to allow a sysadmin to see what's going on when checking their access logs. And I added the link to this repo as a comment value so they can reach this repo and see what it is about. Especially since anyone can use this to maliciously crawl a site. |
I still think it could be a cool feature in cases where you want to run the script from different places at the same time. We can always append the repo's URL to the custom user-agent ! What do you think? |
The cache warmer needs to send a proper and custom User-Agent so access logs on web servers can log the info properly and make it easier for sysadmins to know what's happening.
The text was updated successfully, but these errors were encountered: