Skip to content
This repository has been archived by the owner on Jul 30, 2023. It is now read-only.

care IllegalArgumentException #54

Merged

Conversation

takke
Copy link
Contributor

@takke takke commented Aug 17, 2017

care IllegalArgumentException (e.g. invalid url like "https://mstdn..jp/api/v1/apps")

またまたJavaレイヤーの話で恐縮ですが、不正なURLで apps.createApp すると RuntimeException で落ちるのを防ぎたいです。

  • Crashlytics 的にはこんな感じです http://crashes.to/s/47daee1d9c4
  • Kotlinにmulti-catchがないっぽいのでベタな実装になるのが気持ち悪いです
  • get/patch/delete メソッドでの必要性が分からなかったので postUrl だけ追加しています

@codecov-io
Copy link

Codecov Report

Merging #54 into master will decrease coverage by 0.18%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #54      +/-   ##
============================================
- Coverage     58.13%   57.95%   -0.19%     
  Complexity      147      147              
============================================
  Files            43       43              
  Lines           633      635       +2     
  Branches         60       60              
============================================
  Hits            368      368              
- Misses          251      253       +2     
  Partials         14       14
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/sys1yagi/mastodon4j/MastodonClient.kt 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a02d8a3...61504d2. Read the comment docs.

@sys1yagi
Copy link
Owner

thanks. I will merge & release tonight 🙏

@sys1yagi sys1yagi merged commit 4ea0f23 into sys1yagi:master Aug 18, 2017
@takke takke deleted the fix_not_thrown_exception_from_okhttp3 branch August 20, 2017 09:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants