Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#268 - Introduce units (deg, rad, etc) #278

Merged
merged 3 commits into from
Aug 27, 2020
Merged

#268 - Introduce units (deg, rad, etc) #278

merged 3 commits into from
Aug 27, 2020

Conversation

sys27
Copy link
Owner

@sys27 sys27 commented Aug 26, 2020

No description provided.

@sys27 sys27 added this to the xFunc 4.0.0 milestone Aug 26, 2020
@sys27 sys27 self-assigned this Aug 26, 2020
@sys27 sys27 linked an issue Aug 26, 2020 that may be closed by this pull request
Introduce units (deg, rad, etc) #268
Closed
13 tasks
@codecov
Copy link

codecov bot commented Aug 26, 2020 •
edited

Codecov Report

Merging #278 into dev will increase coverage by 0.74%.
The diff coverage is 98.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #278      +/-   ##
==========================================
+ Coverage   97.06%   97.81%   +0.74%     
==========================================
  Files         149      156       +7     
  Lines        4870     5168     +298     
==========================================
+ Hits         4727     5055     +328     
+ Misses        143      113      -30
Impacted Files Coverage Δ
xFunc.Maths/Analyzers/Differentiator.cs 100.00% <ø> (ø)
xFunc.Maths/MathExtensions.cs 100.00% <ø> (+4.44%) ⬆️
xFunc.Maths/Expressions/Angles/ToNumber.cs 92.30% <92.30%> (ø)
xFunc.Maths/Expressions/Angles/ToDegree.cs 92.85% <92.85%> (ø)
xFunc.Maths/Expressions/Angles/ToGradian.cs 92.85% <92.85%> (ø)
xFunc.Maths/Expressions/Angles/ToRadian.cs 92.85% <92.85%> (ø)
xFunc.Maths/Expressions/Angles/AngleNumber.cs 93.33% <93.33%> (ø)
xFunc.Maths/Expressions/Angles/Angle.cs 98.86% <98.86%> (ø)
...Func.Maths/Analyzers/Formatters/CommonFormatter.cs 100.00% <100.00%> (ø)
xFunc.Maths/Analyzers/Simplifier.cs 100.00% <100.00%> (+0.21%) ⬆️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e47470c...c4cd2e5. Read the comment docs.

@sys27 sys27 force-pushed the feature/angle_units branch 3 times, most recently from f38a78a to a897ce5 Compare August 26, 2020 17:22
@sys27 sys27 changed the title Close #268 - Introduce units (deg, rad, etc) #268 - Introduce units (deg, rad, etc) Aug 26, 2020
sys27
sys27 commented Aug 26, 2020
View reviewed changes
xFunc.Maths/Expressions/Angles/Angle.cs Outdated Show resolved Hide resolved
xFunc.Maths/Expressions/Angles/Angle.cs Outdated Show resolved Hide resolved
xFunc.Maths/Expressions/Angles/Angle.cs Outdated Show resolved Hide resolved
xFunc.Maths/Expressions/Angles/AngleNumber.cs Outdated Show resolved Hide resolved
xFunc.Maths/Analyzers/Formatters/CommonFormatter.cs Outdated Show resolved Hide resolved
xFunc.Maths/Analyzers/TypeAnalyzers/TypeAnalyzer.cs Outdated Show resolved Hide resolved
xFunc.Maths/Analyzers/TypeAnalyzers/TypeAnalyzer.cs Outdated Show resolved Hide resolved
xFunc.Maths/Analyzers/TypeAnalyzers/TypeAnalyzer.cs Show resolved Hide resolved
xFunc.Tests/Tokenization/FunctionLexerTests.cs Outdated Show resolved Hide resolved
@sys27 sys27 force-pushed the feature/angle_units branch 2 times, most recently from 8808b6f to 38ba348 Compare August 27, 2020 08:07
@sys27 sys27 merged commit 0ef3575 into dev Aug 27, 2020
@sys27 sys27 deleted the feature/angle_units branch August 27, 2020 10:32
sys27 added a commit that referenced this pull request Aug 31, 2020
@sys27
#268 - Introduce units (deg, rad, etc) (#278)
4304aa3 
* Rollback to .NET SDK 3.1.302

* Close #268 - Introduce units (deg, rad, etc)

* Fix UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sys27 sys27

Labels
enhancement feature
Projects
None yet
Milestone
xFunc 4.0.0
Development

Successfully merging this pull request may close these issues.

Introduce units (deg, rad, etc)
1 participant
@sys27