Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#457 - Add support for string data type. #458

Merged
merged 1 commit into from Sep 18, 2021
Merged

Conversation

sys27
Copy link
Owner

@sys27 sys27 commented Sep 12, 2021

Closes #457.

@sys27 sys27 added the feature label Sep 12, 2021
@sys27 sys27 added this to the xFunc 4.1.0 milestone Sep 12, 2021
@sys27 sys27 self-assigned this Sep 12, 2021
@codecov
Copy link

codecov bot commented Sep 12, 2021

Codecov Report

Merging #458 (858daa7) into dev (a8ba728) will increase coverage by 0.02%.
The diff coverage is 97.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #458      +/-   ##
==========================================
+ Coverage   99.39%   99.41%   +0.02%     
==========================================
  Files         168      170       +2     
  Lines        6072     6115      +43     
==========================================
+ Hits         6035     6079      +44     
+ Misses         37       36       -1     
Impacted Files Coverage Δ
xFunc.Maths/Expressions/LogicalAndBitwise/Bool.cs 96.42% <ø> (+3.32%) ⬆️
xFunc.Maths/Expressions/Number.cs 100.00% <ø> (+3.22%) ⬆️
xFunc.Maths/Expressions/Units/Unit.cs 100.00% <ø> (+3.84%) ⬆️
xFunc.Maths/Expressions/Variable.cs 100.00% <ø> (ø)
xFunc.Maths/Expressions/StringExpression.cs 92.30% <92.30%> (ø)
...Func.Maths/Analyzers/Formatters/CommonFormatter.cs 100.00% <100.00%> (ø)
...Func.Maths/Analyzers/TypeAnalyzers/TypeAnalyzer.cs 99.87% <100.00%> (+<0.01%) ⬆️
xFunc.Maths/Parser.cs 100.00% <100.00%> (ø)
xFunc.Maths/Tokenization/Lexer.IdToken.cs 100.00% <100.00%> (ø)
xFunc.Maths/Tokenization/Lexer.NumberToken.cs 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8ba728...858daa7. Read the comment docs.

@sys27 sys27 marked this pull request as ready for review September 15, 2021 18:34
@sys27 sys27 merged commit 620db00 into dev Sep 18, 2021
@sys27 sys27 deleted the feature/string-data-type branch September 18, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for string data type
1 participant