Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#308 - Add Convert function #459

Merged
merged 1 commit into from Oct 17, 2021
Merged

#308 - Add Convert function #459

merged 1 commit into from Oct 17, 2021

Conversation

sys27
Copy link
Owner

@sys27 sys27 commented Sep 13, 2021

No description provided.

@sys27 sys27 added this to the xFunc 4.1.0 milestone Sep 13, 2021
@sys27 sys27 self-assigned this Sep 13, 2021
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #459 (003b959) into dev (d99a754) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #459      +/-   ##
==========================================
+ Coverage   99.41%   99.42%   +0.01%     
==========================================
  Files         170      174       +4     
  Lines        6122     6251     +129     
==========================================
+ Hits         6086     6215     +129     
  Misses         36       36              
Impacted Files Coverage Δ
xFunc.Maths/ThrowHelpers.cs 100.00% <ø> (ø)
...Func.Maths/Analyzers/Formatters/CommonFormatter.cs 100.00% <100.00%> (ø)
...Func.Maths/Analyzers/TypeAnalyzers/TypeAnalyzer.cs 99.88% <100.00%> (+<0.01%) ⬆️
xFunc.Maths/Expressions/BinaryExpression.cs 97.05% <100.00%> (ø)
xFunc.Maths/Expressions/Units/Convert.cs 100.00% <100.00%> (ø)
...ths/Expressions/Units/Converters/AngleConverter.cs 100.00% <100.00%> (ø)
...nc.Maths/Expressions/Units/Converters/Converter.cs 100.00% <100.00%> (ø)
...ths/Expressions/Units/Converters/PowerConverter.cs 100.00% <100.00%> (ø)
xFunc.Maths/Parser.ExpressionFactory.cs 100.00% <100.00%> (ø)
xFunc.Maths/Parser.cs 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d99a754...003b959. Read the comment docs.

@sys27 sys27 force-pushed the feature/convert branch 7 times, most recently from 380edf3 to 55db296 Compare October 16, 2021 09:03
@sys27 sys27 force-pushed the feature/convert branch 5 times, most recently from fb85188 to fa86fb0 Compare October 17, 2021 13:14
@sys27 sys27 marked this pull request as ready for review October 17, 2021 13:14
@sys27 sys27 merged commit 1fc975f into dev Oct 17, 2021
@sys27 sys27 deleted the feature/convert branch October 17, 2021 19:09
@sys27 sys27 linked an issue Oct 17, 2021 that may be closed by this pull request
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Units from UnitConverter to xFunc.Maths
1 participant