Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#486 - Add Temperature Unit #487

Merged
merged 1 commit into from Nov 22, 2021
Merged

#486 - Add Temperature Unit #487

merged 1 commit into from Nov 22, 2021

Conversation

sys27
Copy link
Owner

@sys27 sys27 commented Nov 16, 2021

Closes #486

@sys27 sys27 added this to the xFunc 4.1.0 milestone Nov 16, 2021
@sys27 sys27 self-assigned this Nov 16, 2021
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #487 (69d68ef) into dev (d0a7c11) will decrease coverage by 0.08%.
The diff coverage is 97.57%.

❗ Current head 69d68ef differs from pull request most recent head 03f12fb. Consider uploading reports for the commit 03f12fb to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #487      +/-   ##
==========================================
- Coverage   99.42%   99.33%   -0.09%     
==========================================
  Files         174      179       +5     
  Lines        6253     6485     +232     
==========================================
+ Hits         6217     6442     +225     
- Misses         36       43       +7     
Impacted Files Coverage Δ
...nc.Maths/Expressions/Collections/ParameterValue.cs 90.00% <0.00%> (-7.30%) ⬇️
...c.Maths/Expressions/Units/PowerUnits/PowerValue.cs 98.91% <ø> (ø)
xFunc.Maths/Processor.cs 97.36% <50.00%> (-1.29%) ⬇️
.../Expressions/Units/TemperatureUnits/Temperature.cs 75.00% <75.00%> (ø)
...pressions/Units/Converters/TemperatureConverter.cs 95.65% <95.65%> (ø)
...essions/Units/TemperatureUnits/TemperatureValue.cs 98.91% <98.91%> (ø)
...Func.Maths/Analyzers/Formatters/CommonFormatter.cs 100.00% <100.00%> (ø)
...Func.Maths/Analyzers/TypeAnalyzers/TypeAnalyzer.cs 99.88% <100.00%> (+<0.01%) ⬆️
xFunc.Maths/Expressions/Abs.cs 100.00% <100.00%> (ø)
xFunc.Maths/Expressions/Add.cs 100.00% <100.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0a7c11...03f12fb. Read the comment docs.

@sys27 sys27 force-pushed the feature/temperature branch 4 times, most recently from 69d68ef to 4d40718 Compare November 21, 2021 20:24
@sys27 sys27 marked this pull request as ready for review November 22, 2021 10:38
@sys27 sys27 merged commit 67d0c54 into dev Nov 22, 2021
@sys27 sys27 deleted the feature/temperature branch November 22, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Temperature Unit: °C, °F, K
1 participant