Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#489 - Add basic simplification rules for Power and Temperature units. #490

Merged
merged 1 commit into from Dec 13, 2021

Conversation

sys27
Copy link
Owner

@sys27 sys27 commented Dec 13, 2021

Closes #489.

@sys27 sys27 added this to the xFunc 4.1.0 milestone Dec 13, 2021
@sys27 sys27 self-assigned this Dec 13, 2021
@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #490 (fb6ccab) into dev (bedf784) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #490      +/-   ##
==========================================
- Coverage   99.42%   99.20%   -0.23%     
==========================================
  Files         179      179              
  Lines        6490     6510      +20     
==========================================
+ Hits         6453     6458       +5     
- Misses         37       52      +15     
Impacted Files Coverage Δ
xFunc.Maths/Expressions/Div.cs 100.00% <ø> (ø)
xFunc.Maths/Expressions/Mul.cs 100.00% <ø> (ø)
xFunc.Maths/Analyzers/Simplifier.cs 100.00% <100.00%> (ø)
...Func.Maths/Analyzers/TypeAnalyzers/TypeAnalyzer.cs 99.88% <100.00%> (-0.01%) ⬇️
...c.Maths/Expressions/Units/PowerUnits/PowerValue.cs 94.56% <0.00%> (-4.35%) ⬇️
...essions/Units/TemperatureUnits/TemperatureValue.cs 94.56% <0.00%> (-4.35%) ⬇️
xFunc.Maths/Expressions/NumberValue.cs 97.32% <0.00%> (-1.61%) ⬇️
...c.Maths/Expressions/Units/AngleUnits/AngleValue.cs 98.48% <0.00%> (-1.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bedf784...fb6ccab. Read the comment docs.

@sys27 sys27 force-pushed the feature/power-and-temperature-simplification branch from 84d491a to fb6ccab Compare December 13, 2021 21:41
@sys27 sys27 merged commit 95d9704 into dev Dec 13, 2021
@sys27 sys27 deleted the feature/power-and-temperature-simplification branch December 13, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add basic simplification rules for Power and Temperature units
1 participant