Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#544 - Add support of operations on different unit types. #545

Merged
merged 1 commit into from May 10, 2022

Conversation

sys27
Copy link
Owner

@sys27 sys27 commented May 10, 2022

Closes #544

@sys27 sys27 added this to the xFunc 4.1.0 milestone May 10, 2022
@sys27 sys27 self-assigned this May 10, 2022
@sys27 sys27 marked this pull request as ready for review May 10, 2022 06:52
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #545 (48296c8) into dev (dfdc7d3) will decrease coverage by 0.02%.
The diff coverage is 96.36%.

❗ Current head 48296c8 differs from pull request most recent head 016f1d4. Consider uploading reports for the commit 016f1d4 to get more accurate results

@@            Coverage Diff             @@
##              dev     #545      +/-   ##
==========================================
- Coverage   99.56%   99.54%   -0.03%     
==========================================
  Files         206      206              
  Lines        7842     7897      +55     
==========================================
+ Hits         7808     7861      +53     
- Misses         34       36       +2     
Impacted Files Coverage Δ
...Func.Maths/Expressions/Units/AreaUnits/AreaUnit.cs 98.03% <90.90%> (-1.97%) ⬇️
....Maths/Expressions/Units/LengthUnits/LengthUnit.cs 98.57% <94.11%> (-1.43%) ⬇️
xFunc.Maths/Analyzers/Simplifier.cs 100.00% <100.00%> (ø)
...Func.Maths/Analyzers/TypeAnalyzers/TypeAnalyzer.cs 99.90% <100.00%> (+<0.01%) ⬆️
xFunc.Maths/Expressions/Mul.cs 100.00% <100.00%> (ø)
...Maths/Expressions/Units/LengthUnits/LengthValue.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfdc7d3...016f1d4. Read the comment docs.

@sys27 sys27 merged commit ea911f5 into dev May 10, 2022
@sys27 sys27 deleted the feature/unit-operators branch May 10, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support of operations on different unit types
1 participant