This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Use ContactField[] instead of DOMString[] for a few ContactProperties attributes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in vCard v4 specification, the NICKNAME attribute can have a TYPE. Therefore, using ContactField type is more consistent.
This is more consistent with vCard v4 format as the PHOTO attribute can have a TYPE parameter.
This was probably a typo.
|
@cdumez can you please merge upstream? |
|
As discussed in Madrid, extending to ContactField of a number of other attributes seems unjustified unless we find a use case. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in vCard v4 specification, the NICKNAME, TITLE, IMPP, ORG, CATEGORIES and PHOTO attributes can have a TYPE parameter. Therefore, using ContactField type for those is more consistent than DOMString.