This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Remove timezone support from the API #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove timezone support from the API as agreed during the last F2F meeting. This makes the API much simpler, gets rid of the confusing TimezoneDirective argument and avoids a lot of complicated cases related to timezone and DST. We also stop using a Date to schedule an alarm. We now use a DOMTimeStamp, which is a number of milliseconds past the epoch (e.g. Date.now() + n).
|
@marcoscaceres @mounirlamouri What do you think? |
|
Looks great! 👍 |
marcoscaceres
added a commit
that referenced
this pull request
Nov 4, 2013
Remove timezone support from the API
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove timezone support from the API as agreed during the last F2F meeting.
This makes the API much simpler, gets rid of the confusing TimezoneDirective
argument and avoids a lot of complicated cases related to timezone and DST.
We also stop using a Date to schedule an alarm. We now use a DOMTimeStamp,
which is a number of milliseconds past the epoch (e.g. Date.now() + n).