Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRITICAL!!! you use Dash coin code 5 from bip44, please change to 57 - not compatible with coinomi wallet #177

Closed
skironDotNet opened this issue May 2, 2018 · 11 comments

Comments

@skironDotNet
Copy link

the picture shows it all, please use https://coinomi.com/recovery-phrase-tool.html to see syscoin code and bip44 reservation for SYS is 57 https://github.com/satoshilabs/slips/blob/master/slip-0044.md

sys-wrong-code

@sidhujag
Copy link
Member

sidhujag commented May 2, 2018

i can fix but hd support in syscoin 3 is intentionally disabled as it is incomplete and possibly insecure. Dash has this disabled for a reason too. Why are you using HD overriding default?

@skironDotNet
Copy link
Author

because I want to use bip39 recovery from coinomi, unless coinomi will adjust to use DASH the problem is derivation path same address priv/pub will be used for DASH and Syscoin, so privacy issue, identification and so on, bip44 has been created for a reason. I discovered that when trying to import priv key from coinomi sys wallet

@skironDotNet
Copy link
Author

Again this is not about HD, because I don't use any coin wallet, I use bip39 as master for all coins, but it makes no sense to be in Dash derivation path while syscoin has reserved 57. It's easy fix and will benefit all Coinomi users and. Also early fix is important before all people start using a new 3.0 wallet. Those who do use can simply transfer coins to fixed clinet/address generation
bip44

@skironDotNet
Copy link
Author

Can't import SYS address from Coinomi, obviously it expect Dash address format
cant import sys address from bip39

@skironDotNet
Copy link
Author

OK, neither Dash not SYS from Coinomi will import, so now I'm leaning towards Coinomi needs to adjust address format for SYS,
I still stand about derivation path to use code 57 instead of 5

@skironDotNet
Copy link
Author

Ok, BIP32 Root Key from Coinomi match rootkey HD from SYSCOIN 3.0 and and also priv key from bitcoin imports ok. I guess I will use bitcoin addresses for syscoin ...

@skironDotNet
Copy link
Author

Coinomi SYSCOIN public address format is fine, just the private key is wrong... I crunch it for you :)

@skironDotNet
Copy link
Author

Finally, seems like all good. I would still change HD generation to 57 but generally it was Coinomi fault to use wrong WIF number, you can see it here skironDotNet/bip39-passphrase@665c59c

I would still change HD generation to derivation path 57 for SYSCOIN wallet 3.0 (unless I'm wrong but appears as 5 as DASH just private key is encoded as syscoin, so DASH from Coinomi doesn't work due to different WIF number)

@sidhujag
Copy link
Member

sidhujag commented May 2, 2018

ok so hold on... syscoin base58 address prefix starts with "S" in syscoin 3... it will accept bitcoin address scheme but please don't do that if you don't have to. The private key format is the same for all coins based off of bitcoin mostly. I will def change the 57 to 5 thanks for that! Are you saying that if I change it to 5 then the WIF key format will somehow change to be able to importprivkey?

@skironDotNet
Copy link
Author

skironDotNet commented May 2, 2018

No no the prefix starts with "S" in syscoin 3 is ok and was ok, and even ok with Coinomi bip39 tool as is (it just took me some time to figure things out, so my initial concerns/comment not quite valid).

I found out the only reason I could not import private key from Coinomi bip39 tool was Coinomi has wrong WIF number for private key generation.

You should just change to 57 for HD walled derivation so when you test this when "dumpwallet" you should have "hdkeypath=m/44'/57'/0'/0/0" no "hdkeypath=m/44'/5'/0'/0/0" that to be compatible with slip-0044 standard and thus with Coinomi wallet

@sidhujag
Copy link
Member

sidhujag commented May 2, 2018

ok thanks will do sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants