Skip to content

Commit

Permalink
fix: Don't let istio to instrument the webhook
Browse files Browse the repository at this point in the history
Istio and the api-sever does not play pretty well together, like pizza
and pineapple:

* istio/istio#8696
* istio/istio#12187

Chart is open enough for the users to set the podAnnotation with the
api-server instead of not deploying the sidecar in the webhook, but by
default we offer an option that works on most possible scenarios.
  • Loading branch information
Néstor Salceda committed Aug 27, 2021
1 parent 561f3a3 commit a790a5c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions charts/admission-controller/values.yaml
Expand Up @@ -53,6 +53,7 @@ webhook:
prometheus.io/path: "/metrics"
prometheus.io/port: "5000"
prometheus.io/scheme: "https"
sidecar.istio.io/inject: "false"

podSecurityContext: {}

Expand Down

0 comments on commit a790a5c

Please sign in to comment.