Make external_id a required var in webhook-datasource module #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change summary: ---------------- The external_id variable was made optional so as to not break onboarding backend. In the backend, we always ensure passing the external_id to the module, because if not provided, the validation for the same would fail via WIF. Making this required now (as it should be) since backend is all merged.
cgeers
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary:
The
external_idvariable was made optional so as to not break onboarding backend. In the backend, we always ensure passing theexternal_idto the module, because if not provided, the validation for the same would fail via WIF.Making this required now (as it should be) since backend is all merged.