Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash: Importing a Dashboard with unsupported panel types crashes the provider #72

Closed
tembleking opened this issue Jan 11, 2021 · 0 comments · Fixed by #73
Closed

Crash: Importing a Dashboard with unsupported panel types crashes the provider #72

tembleking opened this issue Jan 11, 2021 · 0 comments · Fixed by #73
Assignees
@tembleking
Labels
bug Something isn't working

Comments

@tembleking
Copy link
Member

When a dashboard is being imported but contains panels which are not supported, the provider crashes with a panic.

2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: panic: unreachable code
2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: 
2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: goroutine 57 [running]:
2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: github.com/draios/terraform-provider-sysdig/sysdig.dashboardToResourceData(0xc00000a1e0, 0xc0002f0d00, 0xc000612ae0, 0x2e662)
2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: 	github.com/draios/terraform-provider-sysdig/sysdig/resource_sysdig_monitor_dashboard.go:329 +0xd3b
2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: github.com/draios/terraform-provider-sysdig/sysdig.resourceSysdigDashboardRead(0x19ed100, 0xc000612ae0, 0xc0002f0d00, 0x17f0700, 0xc0001ea380, 0xc00051af80, 0xc0003f78f0, 0x100c9b8)
2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: 	github.com/draios/terraform-provider-sysdig/sysdig/resource_sysdig_monitor_dashboard.go:179 +0x1c6
2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0xc0002e1c80, 0x19ed080, 0xc00052a400, 0xc0002f0d00, 0x17f0700, 0xc0001ea380, 0x0, 0x0, 0x0)
2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: 	github.com/hashicorp/terraform-plugin-sdk/v2@v2.4.0/helper/schema/resource.go:297 +0x1ec
2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).RefreshWithoutUpgrade(0xc0002e1c80, 0x19ed080, 0xc00052a400, 0xc0001f05b0, 0x17f0700, 0xc0001ea380, 0xc00000e2b0, 0x0, 0x0, 0x0)
2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: 	github.com/hashicorp/terraform-plugin-sdk/v2@v2.4.0/helper/schema/resource.go:564 +0x1c2
2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ReadResource(0xc0002c0220, 0x19ed080, 0xc00052a400, 0xc00052a440, 0xc00052a400, 0x1853ea0, 0x1881fa0)
2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: 	github.com/hashicorp/terraform-plugin-sdk/v2@v2.4.0/helper/schema/grpc_provider.go:575 +0x42f
2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: github.com/hashicorp/terraform-plugin-go/tfprotov5/server.(*server).ReadResource(0xc00068d820, 0x19ed080, 0xc00052a400, 0xc000612660, 0xc00068d820, 0xc000096390, 0xc000619ba0)
2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: 	github.com/hashicorp/terraform-plugin-go@v0.2.0/tfprotov5/server/server.go:297 +0x101
2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: github.com/hashicorp/terraform-plugin-go/tfprotov5/internal/tfplugin5._Provider_ReadResource_Handler(0x1881fa0, 0xc00068d820, 0x19ed140, 0xc000096390, 0xc000612600, 0x0, 0x19ed140, 0xc000096390, 0xc0003aa280, 0x123)
2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: 	github.com/hashicorp/terraform-plugin-go@v0.2.0/tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go:344 +0x217
2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: google.golang.org/grpc.(*Server).processUnaryRPC(0xc0002de1c0, 0x19f6520, 0xc00050ac00, 0xc0001cc200, 0xc000690510, 0x1f3c550, 0x0, 0x0, 0x0)
2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: 	google.golang.org/grpc@v1.34.0/server.go:1210 +0x50a
2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: google.golang.org/grpc.(*Server).handleStream(0xc0002de1c0, 0x19f6520, 0xc00050ac00, 0xc0001cc200, 0x0)
2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: 	google.golang.org/grpc@v1.34.0/server.go:1533 +0xcfd
2021-01-08T08:39:25.803Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: google.golang.org/grpc.(*Server).serveStreams.func1.2(0xc0002b6410, 0xc0002de1c0, 0x19f6520, 0xc00050ac00, 0xc0001cc200)
2021-01-08T08:39:25.804Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: 	google.golang.org/grpc@v1.34.0/server.go:871 +0xa1
2021-01-08T08:39:25.804Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: created by google.golang.org/grpc.(*Server).serveStreams.func1
2021-01-08T08:39:25.804Z [DEBUG] plugin.terraform-provider-sysdig_v0.5.8: 	google.golang.org/grpc@v1.34.0/server.go:869 +0x204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tembleking tembleking

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Solve crash when importing unsupported dashboard panels sysdiglabs/terraform-provider-sysdig
1 participant
@tembleking