🌱 Suffixing placement group names in Hetzner

Using cluster name as suffix for placement group names to avoid
colliding naming of placement groups belonging to different clusters in
the same project.

main.go

@@ -61,7 +61,7 @@ var (
 )
 
 func main() {
-	flag.BoolVar(&verbose, "verbose", true, "Enable verbose logging")
+	flag.BoolVar(&verbose, "verbose", false, "Enable verbose logging")
 
 	flag.StringVar(&metricsAddr, "metrics-bind-address", "localhost:8080", "The address the metric endpoint binds to.")
 	flag.StringVar(&probeAddr, "health-probe-bind-address", ":8081", "The address the probe endpoint binds to.")
@@ -73,7 +73,7 @@ func main() {
 	flag.StringVar(&watchNamespace, "namespace", "", "Namespace that the controller watches to reconcile cluster-api objects. If unspecified, the controller watches for cluster-api objects across all namespaces.")
 
 	opts := zap.Options{
-		Development: true,
+		Development: verbose,
 	}
 	opts.BindFlags(flag.CommandLine)
 	flag.Parse()

pkg/services/hcloud/placementgroup/placementgroup.go

@@ -19,6 +19,8 @@ package placementgroup
 
 import (
 	"context"
+	"fmt"
+	"strings"
 
 	"github.com/hetznercloud/hcloud-go/hcloud"
 	"github.com/pkg/errors"
@@ -35,6 +37,8 @@ type Service struct {
 	scope *scope.ClusterScope
 }
 
+const pgDelimiter = "-"
+
 // NewService creates new service object.
 func NewService(scope *scope.ClusterScope) *Service {
 	return &Service{
@@ -88,9 +92,10 @@ func (s *Service) Reconcile(ctx context.Context) (err error) {
 			}
 		}
 		if !foundInStatus {
+			name := fmt.Sprintf("%s%s%s", s.scope.HetznerCluster.Name, pgDelimiter, pgSpec.Name)
 			clusterTagKey := infrav1.ClusterTagKey(s.scope.HetznerCluster.Name)
 			if _, _, err := s.scope.HCloudClient().CreatePlacementGroup(ctx, hcloud.PlacementGroupCreateOpts{
-				Name:   pgSpec.Name,
+				Name:   name,
 				Type:   hcloud.PlacementGroupType(pgSpec.Type),
 				Labels: map[string]string{clusterTagKey: string(infrav1.ResourceLifecycleOwned)},
 			}); err != nil {
@@ -154,7 +159,7 @@ func (s *Service) apiToStatus(placementGroups []*hcloud.PlacementGroup) (status
 		status = append(status, infrav1.HCloudPlacementGroupStatus{
 			ID:     pg.ID,
 			Server: pg.Servers,
-			Name:   pg.Name,
+			Name:   strings.Split(pg.Name, pgDelimiter)[1],
 			Type:   string(pg.Type),
 		})
 	}