New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Skip machines with one WWN, if RAID is desired. #1162
🌱 Skip machines with one WWN, if RAID is desired. #1162
Conversation
10785c7
to
8b70456
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something that happens often?
This should be documented accordingly. Right now people probably try to do this and wonder why the host does not get chosen.
Should we also include a log or event for this?
86e1cdf
to
88bd718
Compare
in 88bd718 i added a "reason", so that users understand why hosts were not picked. |
d286906
to
e151722
Compare
cdbb078
to
de9c340
Compare
@janiskemper please review |
did you do more than fixing the test? If not, I'll approve |
tiny changes got done: I increased the log-level so that the message is actually visible:
if there is no available host, then the error message is more explicit now:
|
a7eb356
to
5246350
Compare
Additionally a better error message gets returned, if no matching HetznerBaremetalHost was found.
5246350
to
6fdeb96
Compare
What this PR does / why we need it:
Skip machines with one WWN, if RAID is desired.
Fixes #1122
Special notes for your reviewer:
TODOs: