Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Script to detect invalid WWN/RAID configuration of hbmh. #1164

Merged
merged 1 commit into from Mar 7, 2024
Merged

🐛 Script to detect invalid WWN/RAID configuration of hbmh. #1164

merged 1 commit into from Mar 7, 2024

Conversation

guettli
Copy link
Contributor

@guettli guettli commented Feb 14, 2024 •
edited

If the WWN configuration of a hbmh is invalid, this PR detects that and creates a corresponding Event and Condition.

We think about doing that in Go with go-diskfs

Update: We will stick to the shell script. It works.

@guettli guettli force-pushed the tg/detect-wwn-confusion branch 2 times, most recently from fb88b61 to aad07eb Compare February 14, 2024 11:02
@guettli guettli changed the title 🐛 Detect invalid WWN configuration of hbmh. 🐛 Detect invalid WWN/RAID configuration of hbmh. Feb 29, 2024
@guettli guettli marked this pull request as draft February 29, 2024 11:44
@guettli guettli changed the title 🐛 Detect invalid WWN/RAID configuration of hbmh. 🐛 Script to detect invalid WWN/RAID configuration of hbmh. Mar 1, 2024
@guettli guettli requested a review from janiskemper March 5, 2024 08:35
@guettli guettli marked this pull request as ready for review March 5, 2024 08:36
@syself-bot syself-bot bot added area/hack Changes made in the hack directory area/code Changes made in the code directory area/api Changes made in the api directory size/M Denotes a PR that changes 50-200 lines, ignoring generated files. labels Mar 5, 2024
janiskemper
janiskemper previously requested changes Mar 6, 2024
View reviewed changes
pkg/services/baremetal/host/host.go Outdated Show resolved Hide resolved
@guettli guettli requested a review from janiskemper March 6, 2024 10:02
janiskemper
janiskemper reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@janiskemper janiskemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small grammar improvement. Otherwise looks good

pkg/services/baremetal/client/ssh/ssh_client.go Outdated Show resolved Hide resolved
@guettli guettli requested a review from janiskemper March 6, 2024 16:03
@syself-bot syself-bot bot added the area/test Changes made in the test directory label Mar 6, 2024
@janiskemper
Copy link
Contributor

there are linting issues. I think you accidentally exported your variable

@guettli
Copy link
Contributor Author

guettli commented Mar 6, 2024

there are linting issues. I think you accidentally exported your variable

fixed

janiskemper
janiskemper reviewed Mar 6, 2024
View reviewed changes
test/e2e/Makefile Outdated Show resolved Hide resolved
@guettli guettli requested a review from janiskemper March 7, 2024 07:03
@guettli guettli merged commit 03ed605 into main Mar 7, 2024
9 checks passed
@guettli guettli deleted the tg/detect-wwn-confusion branch March 7, 2024 08:25
@guettli guettli mentioned this pull request Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniruddha2000 aniruddha2000 aniruddha2000 approved these changes

@janiskemper janiskemper Awaiting requested review from janiskemper

Assignees
No one assigned
Labels
area/api Changes made in the api directory area/code Changes made in the code directory area/hack Changes made in the hack directory area/test Changes made in the test directory size/M Denotes a PR that changes 50-200 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guettli @janiskemper @aniruddha2000