Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 update hetzner-baremetal guide #1182

Merged
merged 1 commit into from
Apr 9, 2024
Merged

📖 update hetzner-baremetal guide #1182

merged 1 commit into from
Apr 9, 2024

Conversation

Sayanta66
Copy link
Contributor

What this PR does / why we need it:

Docs restructuring which includes the rewriting of the quickstart guide by means of addition and eliminations. Baremetal and node image contents are separated.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@Sayanta66 Sayanta66 self-assigned this Feb 23, 2024
@Sayanta66 Sayanta66 force-pushed the caphdocss branch 3 times, most recently from 32e31ea to 6af0352 Compare February 23, 2024 14:12
@Sayanta66 Sayanta66 changed the title 📖 Updating the Quickstart guide of CAPH doc [WIP] 📖 Updating and revamping CAPH doc entirely [WIP] Feb 26, 2024
@Sayanta66
Copy link
Contributor Author

@janiskemper @kranurag7 - Can you both take a look at the new changes?

@kranurag7 kranurag7 force-pushed the caphdocss branch 2 times, most recently from 197b5d3 to 39bb9f6 Compare April 4, 2024 12:03
docs/topics/hetzner-baremetal.md Outdated Show resolved Hide resolved
docs/topics/hetzner-baremetal.md Outdated Show resolved Hide resolved
docs/topics/hetzner-baremetal.md Show resolved Hide resolved
docs/topics/hetzner-baremetal.md Outdated Show resolved Hide resolved
docs/topics/hetzner-baremetal.md Outdated Show resolved Hide resolved
docs/topics/hetzner-baremetal.md Show resolved Hide resolved
docs/topics/hetzner-baremetal.md Outdated Show resolved Hide resolved
docs/topics/hetzner-baremetal.md Outdated Show resolved Hide resolved
docs/topics/hetzner-baremetal.md Outdated Show resolved Hide resolved
docs/topics/hetzner-baremetal.md Show resolved Hide resolved
docs/topics/hetzner-baremetal.md Outdated Show resolved Hide resolved
docs/topics/hetzner-baremetal.md Outdated Show resolved Hide resolved
docs/topics/hetzner-baremetal.md Outdated Show resolved Hide resolved
docs/topics/hetzner-baremetal.md Show resolved Hide resolved
@janiskemper
Copy link
Contributor

looks good!

Update hetznerbaremetalhost_types.go

Signed-off-by: kranurag7 <anurag.kumar@syself.com>
Co-authored-by: janiskemper <63146658+janiskemper@users.noreply.github.com>
@kranurag7 kranurag7 marked this pull request as ready for review April 9, 2024 14:43
@kranurag7 kranurag7 changed the title 📖 Updating and revamping CAPH doc entirely [WIP] 📖 update hetzner-baremetal guide Apr 9, 2024
@kranurag7 kranurag7 merged commit 5ecce88 into main Apr 9, 2024
8 checks passed
@kranurag7 kranurag7 deleted the caphdocss branch April 9, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants