Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Always create UEFI partition #1190

Merged
merged 2 commits into from Mar 5, 2024
Merged

Conversation

guettli
Copy link
Contributor

@guettli guettli commented Mar 1, 2024

What this PR does / why we need it:

This PR changes provisioning bare-metal machines. From now on we always create an UEFI boot partition.

This wastes 514MByte for systems without UEFI, but we think that should not matter much.

This should fix #1118

Boot order is important

If the machine does not enter the rescue system, then the UEFI boot order of the machine might be wrong.

If booting from disk is before network-boot, then the rescue system can't be reached.

See output of efibootmgr.

To change the boot-order, you need to contact the support of Hetzner.

Manual changes to the boot order via efibootmgr -o ... seem to be overwritten automatically by the infrastructure provider.

TODO

  • Test with a machine with legacy BIOS (demo account: the one from germany: FSN1-DC8)
  • Test with a machine with UEFI (demo account: AX41)

on the ax41 (after the node is running). Check for uefi support:

root@... ~ # efibootmgr 

If you see that, then uefi is NOT running:

EFI variables are not supported on this system.

@syself-bot syself-bot bot added size/XS Denotes a PR that changes 0-20 lines, ignoring generated files. area/code Changes made in the code directory labels Mar 1, 2024
lucasrattz
lucasrattz previously approved these changes Mar 1, 2024
@syself-bot syself-bot bot added the area/templates Changes made in the templates directory label Mar 1, 2024
@guettli guettli merged commit ad6bb54 into main Mar 5, 2024
5 checks passed
@guettli guettli deleted the tg/always-create-uefi-esp-partition branch March 5, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code Changes made in the code directory area/templates Changes made in the templates directory size/XS Denotes a PR that changes 0-20 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provisioning of UEFI machines not possible
3 participants