Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Fix getting NIC info if more than one card was found. #1205

Merged
merged 1 commit into from Mar 13, 2024

Conversation

guettli
Copy link
Contributor

@guettli guettli commented Mar 12, 2024

What this PR does / why we need it:

If a bare-metal machine has several network interface cards, the provisioning did fail.

Fixes #939

Caveat

The PR makes the provisioning no longer fail.

BUT: Getting the INFO is broken in several ways:

  • SPEED gets always fetched from eth0. It should be $iname instead.
  • Getting the NIC via grepping lspci is not reliable. The name does not match to $iname.

Getting the NIC info in a more reliable way is a different PR.

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@guettli guettli marked this pull request as ready for review March 12, 2024 20:15
@syself-bot syself-bot bot added the area/code Changes made in the code directory label Mar 12, 2024
@guettli guettli merged commit c6fd5bb into main Mar 13, 2024
14 checks passed
@guettli guettli deleted the tg/fix-multi-nic-issue939 branch March 13, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code Changes made in the code directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconcile error for HetznerBareMetalHost and more than one network interface
2 participants