Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Handle rate limit errors in HCloud #144

Merged
merged 1 commit into from Apr 8, 2022

Conversation

janiskemper
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
We now wait for a fixed time if a rate limit error occurs while
reconciling a machine or the cluster object. The logic relies on
conditions, where RateLimitExceeded is set to true. The machine and
cluster controller requeue reconciling at the beginning for a fixed time
period, until the waiting time is over and the reconciling can start
again.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

We now wait for a fixed time if a rate limit error occurs while
reconciling a machine or the cluster object. The logic relies on
conditions, where RateLimitExceeded is set to true. The machine and
cluster controller requeue reconciling at the beginning for a fixed time
period, until the waiting time is over and the reconciling can start
again.
@janiskemper janiskemper force-pushed the feature/handle-rate-limits-hcloud branch from 52523b0 to d15f023 Compare April 8, 2022 10:09
@batistein batistein merged commit 3504e68 into main Apr 8, 2022
@batistein batistein deleted the feature/handle-rate-limits-hcloud branch April 8, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants