✨ Add specs to choose public net #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janiskemper
force-pushed
the
feature/select-public-net
branch
5 times, most recently
from
e6155a6
to
d740d9d
Compare
Hetzner has released a new feature in https://github.com/hetznercloud/hcloud-go/releases/tag/v1.35.0 that allows to choose the primary IP address of an HCloud server on creation. This commit introduces support for this.
janiskemper
force-pushed
the
feature/select-public-net
branch
from
d740d9d
to
8d5d9bc
Compare
Wouter0100
reviewed
Jul 7, 2022
Comment on lines
+582
to
+583
| // Only if server has IPv4, otherwise Hetzner cannot handle it | ||
| if server.PublicNet.IPv4.IP != nil { |
There was a problem hiding this comment.
Won't this if-statement break the use of a private IPv4 addresses in the Load Balancer as well? This seems because the hasPrivateIP-var is not taken into consideration in this if-statement.
Or, doesn't Hetzner support private IPv4 adresses without public IPv4 being attached?
There was a problem hiding this comment.
Hi @Wouter0100! This is a great catch, thank you!
We would have found this problem before the next release because we would have added some e2e tests for this setup without IPv4 addresses. But you saved us definitely some time since we don't have to search for the error anymore. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature New functionality.
What this PR does / why we need it:
Hetzner has released a new feature in
https://github.com/hetznercloud/hcloud-go/releases/tag/v1.35.0 that
allows choosing the primary IP address of an HCloud server on creation.
This commit introduces support for this.
Which issue(s) this PR fixes
Fixes #233
TODOs: