🐛 Fix add server to lb with only private IP #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janiskemper
changed the title
janiskemper
force-pushed
the
fix/lb-server-private-net
branch
from
24485c8
to
44e749f
Compare
In one of the last PRs we added support for Hetzner's new feature of disabling IPv4 and IPv6 addresses. This required to prevent servers from being added to load balancer in case they only have IPv6 addresses - as no IPv6 addresses can be added to a Hetzner load balancer. This only applies to public network though. This is why we also need to add servers in case that private networks are there - independent whether there is a public IPv4 or not.
janiskemper
force-pushed
the
fix/lb-server-private-net
branch
from
44e749f
to
03b9d7d
Compare
batistein
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
In one of the last PRs we added support for Hetzner's new feature of
disabling IPv4 and IPv6 addresses. This required to prevent servers from
being added to load balancer in case they only have IPv6 addresses - as
no IPv6 addresses can be added to a Hetzner load balancer. This only
applies to public network though. This is why we also need to add
servers in case that private networks are there - independent whether
there is a public IPv4 or not.
TODOs: