Fix rebuilding of all virtual modules on any change for webpack 4

[non25]

What's the problem this PR addresses?

Test lets us know more about virtual modules getting reloaded and rebuilt.

How did you fix it?

The problem of reloading and rebuilding every virtual module on any change is not fixed yet.

[non25]

I've managed to make old fix work both on webpack 4 and 5, but I can't understand how to make automated tests work too...
Would like to get some help.

Interesting, ln -sf doesn't overwrite previous symbolic link so I haven't tested anything propely...

[non25]

So previous fix, which consist of populating compiler.fileTimestamps Map like this:

Object.keys(virtualFiles).forEach((file) => {
  compiler.fileTimestamps.set(file, +virtualFiles[file].stats.mtime);
});

still works for Webpack 4 in development mode and fixes rebuilds.

mode: 'development' crashes Webpack 3, but fix has no effect on it anyway.

Looks like Webpack 5 doesn't have compiler.fileTimestamps and we should look for other options.

I've disabled test for Webpack 3 and 5 until we find a solution.
Fix doesn't affect Webpack 3 and 5.

[larixer]

Awesome, many thanks Kirill!

[larixer]

Published webpack-virtual-modules@0.4.1

[jquense]

this change seems to break reloading for any file for webpack 5. I've been testing it locally, and rebuilds of the files still happen but they don't make it to the compilation, e.g. the file after the rebuild is still the old code.

[non25]

this change seems to break reloading for any file for webpack 5. I've been testing it locally, and rebuilds of the files still happen but they don't make it to the compilation, e.g. the file after the rebuild is still the old code.

So if you remove this code

webpack-virtual-modules/src/index.ts

Lines 262 to 268 in 95e79ab

	const virtualFiles = (compiler as any).inputFileSystem._virtualFiles;
	const fts = compiler.fileTimestamps as any;
	if (virtualFiles && fts && typeof fts.set === 'function') {
	Object.keys(virtualFiles).forEach((file) => {
	fts.set(file, +virtualFiles[file].stats.mtime);
	});
	}

it starts to work normally?

Webpack 5 doesn't have compiler.fileTimestamps, so condition in this code won't pass. You can try to console.log from it to confirm, but I'm quite positive that it shouldn't affect webpack 3 and 5 at all.

[jquense]

Webpack 5 doesn't have compiler.fileTimestamps

I'm not seeing that, it's not supposed to have it but it does exist for back compat:

at least ion 5.1.3. guarding here using webpack.version fixed it for me

[non25]

Can you make reproduction repo ?
Can't reproduce the problem with webpack 5.3 and webpack 5.10.
https://github.com/non25/webpack-virtual-modules/tree/repro-no-rebuilds