Skip to content

Commit

Permalink
devshell: create workaround for python 3.10 on Debian Testing
Browse files Browse the repository at this point in the history
pre-commit doesn't work on Debian Testing after
python is upgraded to 3.10.

It seems that this issue is only resolved in python 3.11 [4]

```
1. pre-commit/pre-commit#2299
2. pre-commit/pre-commit#2336
3. https://bugs.launchpad.net/ubuntu/+source/python3.10/+bug/1967920
4. python/cpython#89576
```

Signed-off-by: Gabor Nagy <gabor.nagy@oneidentity.com>
  • Loading branch information
Gabor Nagy committed Apr 26, 2022
1 parent 7b41872 commit e61d4cf
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/devshell.yml
Expand Up @@ -216,9 +216,14 @@ jobs:
id: light-style-check
if: always()
working-directory: ./build
shell: bash
run: |
python3.9 -m venv venv
source venv/bin/activate
python -m pip install -r "${GITHUB_WORKSPACE}/requirements.txt"
make light-linters || \
(git diff > ../light-style-problems.diff ; git reset --hard HEAD && exit 1)
deactivate
- name: "Artifact: c-style-problems"
uses: actions/upload-artifact@v2
Expand Down
5 changes: 5 additions & 0 deletions dbld/packages.manifest
Expand Up @@ -96,6 +96,11 @@ python3-dev [ubuntu-focal]
python-pip [centos, fedora, debian-stretch, debian-buster, ubuntu-trusty, ubuntu-xenial, ubuntu-bionic]
python3-pip [debian, ubuntu]

# python 3.10 has issues on Debian Testing
# Nevertheless we should only downgrade for Light style-check tests, which uses pre-commit
python3.9 [devshell]
python3.9-venv [devshell]

# libmongoc and libbson packages on various platforms
# Because we are using fixed version of libmongoc on Bionic, we need to
# specify non versioned packages on other platforms to continiously support
Expand Down

0 comments on commit e61d4cf

Please sign in to comment.