logproto: do not enable position tracking by default #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
kvch
approved these changes
Sep 15, 2016
There was a performance issue around TCP source. As it came out LateAckTracker was used instead of EarlyAckTracker. The reason was that position tracking was enabled by default for the LogProto type that is used for TCP source. Signed-off-by: Laszlo Budai <Laszlo.Budai@balabit.com>
lbudai
force-pushed
the
f/logproto-text-server-pos-tracking
branch
from
0ced34a
to
e2c6835
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a performance issue around TCP source.
As it came out LateAckTracker was used instead of EarlyAckTracker.
The reason was that position tracking was enabled by default for the
LogProto type that is used for TCP source.
Signed-off-by: Laszlo Budai Laszlo.Budai@balabit.com