openssl: replace deprecated thread callback function #1397
Conversation
|
Fixes option #1396. |
|
This user does not have permission to start the build. Can one of the admins verify this patch and start the build? (admin please type: ok to test) |
|
I have sent you a pull request to improve the conditionals somewhat, if you can add it on top of yours, you get my 👍 @kira-syslogng please test |
|
What about applying the point fix, then doing a broader refactoring of OpenSSL version specific code paths? |
|
Well, I've submitted a separate patch, so yours will remain the low-touch-point one. No need to fold it in. Just merge it in your branch so I can merge both with a single PR. Or is there any other problems I might be missing? |
Done. |
|
@kira-syslogng ok to test. |
|
Build ERROR |
|
@kira-syslogng retest this please. |
|
Build ERROR |
pprindeville
force-pushed
the
drop-CRYPTO_set_id_callback
branch
from
479d6bc
to
db1ee85
Compare
|
I can't see the kira results... the link Details doesn't resolve. |
|
@kira-syslogng retest this please. |
|
@bazsi I've rebased without your PR merged, so you can commit it separately per above. Thanks. |
|
Build ERROR |
|
I'm seeing this message "Kira - 305 tests run, 0 skipped, 2 failed." but I can't figure out how to get a look at what those tests were. Can someone please explain what I'm doing wrong? Thanks |
CRYPTO_set_id_callback (openssl<1.0.0) has been replaced by CRYPTO_THREADID_set_callback. Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
pprindeville
force-pushed
the
drop-CRYPTO_set_id_callback
branch
from
db1ee85
to
2fc0ecb
Compare
|
Build ERROR |
|
Hi,
Ill take care about that. That's an experimental system, which Balabit
would publish, but right now it runs internally on balabit infrastructure.
…On Mar 28, 2017 2:49 AM, "kira-syslogng" ***@***.***> wrote:
Build ERROR
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1397 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AArldnMghMEPMFrQfLwRG8CMCU7A016dks5rqFkngaJpZM4Mo9G6>
.
|
So, is anything actually failing to build or not? |
|
There's a failing testcase, seems to be unrelated to this PR. |
|
Hi, The failing test case is not related to this patch, we're going to fix the problem ASAP. |
|
@kira-syslogng retest this please. |
|
Build SUCCESS |
|
@bazsi Can you please close your review? Are we good to merge now? |
|
@pprindeville : thanks for the PR. |
|
Thanks! |
|
BTW, what's the next version of syslog-ng and when is it due out? Thanks |
CRYPTO_set_id_callback (openssl<1.0.0) has been replaced by
CRYPTO_THREADID_set_callback.
Signed-off-by: Philip Prindeville philipp@redfish-solutions.com