python-dest: string compatibility for python3 #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build FAILURE, the tests were executed on test branch: master and test suite: functions |
|
Build FAILURE, the tests were executed on test branch: master and test suite: functions |
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
|
Build FAILURE, $TEST_DESC_COMMENT |
|
@kira-syslogng retest this please |
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
Two changes in python3 c api compared to python2 1) In python3, all strings are utf8, so PyBytes_Check will fail. This patch will use PyUnicode_Check for python3 instead. 2) The function PyBytes_AsString is removed in python3. This patch will use PyUnicode_AsUTF8 instead. Signed-off-by: Antal Nemes <antal.nemes@balabit.com>
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
bazsi
approved these changes
Sep 5, 2017
furiel
added a commit
to furiel/syslog-ng
that referenced
this pull request
Sep 7, 2017
Introduced in: syslog-ng#1632 A distribution might not label python pkg-config pc file as python2 or python3. In such case auto-detection will not work. In case of autodetection, we will look for pc files in this order: python3, python2, python. This will work on even archlinux where only python2 or python3 is used. The decision between v2 and v3 will be done later by a call to AC_CHECK_FUNCS instead. Signed-off-by: Antal Nemes <antal.nemes@balabit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes in python3 c api compared to python2:
patch will use PyUnicode_Check for python3 instead.
will use PyUnicode_AsUTF8 instead.
Fixes: #1363