add-contextual-data: make ordering optional #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build FAILURE, the tests were executed on test branch: master and test suite: functions |
Template based selection does not require ordering, so the time complexity of this operation is unnecessary here. Signed-off-by: László Várady <laszlo.varady@balabit.com>
MrAnno
force-pushed
the
acd-optional-ordering
branch
from
a68a08d
to
bff2c2a
Compare
|
Build SUCCESS, the tests were executed on test branch: master and test suite: functions |
lbudai
approved these changes
Aug 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request breaks the API of
AddContextualDataSelector, so it MUST be merged together with our internal modules (branchname: acd-optional-ordering)Template based selection does not require ordering, so the time complexity of this operation is unnecessary here.
Fixes #1439