Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tags-parser: new module to parse $TAGS values #1658

Merged
merged 3 commits into from Sep 13, 2017
Merged

tags-parser: new module to parse $TAGS values #1658

merged 3 commits into from Sep 13, 2017

Conversation

bazsi
Copy link
Collaborator

@bazsi bazsi commented Sep 4, 2017

The new tags-parser() takes a value encoded by $TAGS and parses it
back into actual tags on the message.

Example:

tags-parser(template("$PROGRAM"));

@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

@@ -0,0 +1,83 @@
/*
* Copyright (c) 2002-2015 Balabit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The year in copyright can be updated to 2017. The other copyright sections look ok.

@furiel
Copy link
Collaborator

furiel commented Sep 6, 2017

Looks ok to me. Once travis is green, I think we can merge this.

@bazsi
Copy link
Collaborator Author

bazsi commented Sep 6, 2017

I have now added unit tests, so this should be good enough for merging.

@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

@@ -0,0 +1,12 @@
modules_tagsparser_tests_TESTS = modules/tagsparser/tests/test_tagsparser
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add if ENABLE_CRITERION here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

1 similar comment
@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
The new tags-parser() takes a value encoded by $TAGS and parses it
back into actual tags on the message.

Example:

	tags-parser(template("$PROGRAM"));

Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

@bazsi
Copy link
Collaborator Author

bazsi commented Sep 13, 2017

We've discussed this IRL, is a standalone plugin with unit tests, so it is ready to go in.

@bazsi bazsi merged commit a018b46 into master Sep 13, 2017
@MrAnno MrAnno deleted the tags-parser branch April 15, 2018 21:41
@MrAnno
Copy link
Collaborator

MrAnno commented Aug 15, 2019

@fekete-robert This is a really nice feature that we forgot to add to the documentation.

It is possible to forward $TAGS in syslog messages, the documentation mentions this as a note:
https://www.syslog-ng.com/technical-documents/doc/syslog-ng-open-source-edition/3.22/administration-guide/58#TOPIC-1209290

tags-parser() is the inverse of this functionality, it parses $TAGS back to real tags.

@fekete-robert
Copy link
Collaborator

fekete-robert commented Aug 21, 2019 via email

@MrAnno
Copy link
Collaborator

MrAnno commented Aug 21, 2019

@fekete-robert Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants