Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang compile error because of -Werror #1662

Merged
merged 3 commits into from Sep 12, 2017
Merged

Clang compile error because of -Werror #1662

merged 3 commits into from Sep 12, 2017

Conversation

Kokan
Copy link
Collaborator

@Kokan Kokan commented Sep 8, 2017

Signed-off-by: kokan peter.kokai@balabit.com

@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

@bazsi
Copy link
Collaborator

bazsi commented Sep 10, 2017

what was the issue here? I can't deduce that from the patch alone.

@Kokan
Copy link
Collaborator Author

Kokan commented Sep 10, 2017

@bazsi The initial issue is that the master does not compile with clang.

But as it turned out, this is not the only issue with the clang compiling. This is a WIP till I fix all compile related issue. (the title is misleading because I thought this is the only issue.)

As for the utmp part:
During configure we try to detect if modern utmp is used via checking if the ut.ut_user field exists.
But in clang the code which checked contained warnings, the travis compiles it with -Werror, thus the check always said modern utmp is not supported, cause latter compile error.

@Kokan
Copy link
Collaborator Author

Kokan commented Sep 10, 2017

The rest of this issue is actually comes from https://github.com/alanxz/rabbitmq-c .
This library does not compile with clang-3.9 and -Werror.
See the details in alanxz/rabbitmq-c#440

@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

1 similar comment
@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

Fix utmp modern detection in case of clang -Werror
684c1f6 
Signed-off-by: kokan <peter.kokai@balabit.com>
@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

@Kokan Kokan force-pushed the utmp-modern-compile-fix branch 2 times, most recently from 1c86fb8 to ed2b8a6 Compare September 12, 2017 07:20
@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

@bazsi
Copy link
Collaborator

bazsi commented Sep 12, 2017

Can we merge this ASAP? This causes travis to be red for me as well. Thanks.

the configure change looks ok to me. I don't know about librabbitmq.

@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

1 similar comment
@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

rabbitmq-c updated to fix compile error
fd6a8a9 
rabbitmq depricated call amqp_ssl_socket_set_verify

Signed-off-by: kokan <peter.kokai@balabit.com>
@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

disable mongodb for clang
c24ca74 
Signed-off-by: kokan <peter.kokai@balabit.com>
@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

@Kokan Kokan changed the title Fix utmp modern detection in case of clang -Werror Clang compile error because of -Werror Sep 12, 2017
@kira-syslogng
Copy link
Contributor

Build SUCCESS, the tests were executed on test branch: master and test suite: functions

@lbudai lbudai merged commit 8f519a4 into syslog-ng:master Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbudai lbudai lbudai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kokan @kira-syslogng @bazsi @lbudai